Fix TemplateBinding in custom IControlTemplate implementations #17427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
bug
area-xaml
customer-priority
maxkatz6
approved these changes
Nov 4, 2024
|
You can test this PR using the following package version. |
I reported it via the customer support system. We have multiple custom template types (data, control, itemspanel...) which capture and restore a dependency injection context. This allows controls generated after the window opens (e.g. virtualised list items) to find the correct dependencies. |
|
You can test this PR using the following package version. |
maxkatz6
added a commit
that referenced
this pull request
Nov 14, 2024
* Add failing test for TemplateBinding inside custom control template * Fix TemplateBinding XAML compilation error for custom IControlTemplate --------- Co-authored-by: Max Katz <[email protected]>
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR allows
TemplateBindingto work inside customIControlTemplateimplementations.A unit test has been added.
What is the current behavior?
The XAML compiler fails with AVLN3000: Unable to find the ControlTemplate scope for AvaloniaProperty lookup
What is the updated/expected behavior with this PR?
TemplateBindingworks inside any implementation ofIControlTemplate.